FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
160 46 0 0

Files

Class Bugs
BluetoothTCKAgent.BluetoothTCKAgent 1
BluetoothTCKAgent.DiscoveryListenerImpl 4
BluetoothTCKAgent.GOEPThread 1
BluetoothTCKAgent.GOEPThread$RequestHandlerImpl 2
BluetoothTCKAgent.L2CAPThread 5
BluetoothTCKAgent.PushBTConnectionThread 7
BluetoothTCKAgent.System 1
BluetoothTCKAgent.TCKAgentUtil 15
OBEXTCKAgent.OBEXTCKAgentApp 4
OBEXTCKAgent.OBEXTCKAgentApp$MyAuthenticator 3
OBEXTCKAgent.OBEXTCKAgentApp$RequestHandlerImpl 2
org.bluecove.tester.tck.TckCanvas 1

BluetoothTCKAgent.BluetoothTCKAgent

Bug Category Details Line
Unread field: BluetoothTCKAgent.BluetoothTCKAgent.DEFAULT_PORT; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 45

BluetoothTCKAgent.DiscoveryListenerImpl

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 81
BluetoothTCKAgent.DiscoveryListenerImpl.getRecordArray() may expose internal representation by returning DiscoveryListenerImpl.sRecord MALICIOUS_CODE EI_EXPOSE_REP 165
BluetoothTCKAgent.DiscoveryListenerImpl.servicesDiscovered(int, ServiceRecord[]) may expose internal representation by storing an externally mutable object into DiscoveryListenerImpl.sRecord MALICIOUS_CODE EI_EXPOSE_REP2 110
Unused field: BluetoothTCKAgent.DiscoveryListenerImpl.server PERFORMANCE UUF_UNUSED_FIELD Not available

BluetoothTCKAgent.GOEPThread

Bug Category Details Line
BluetoothTCKAgent.GOEPThread.run() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 89

BluetoothTCKAgent.GOEPThread$RequestHandlerImpl

Bug Category Details Line
Method call in BluetoothTCKAgent.GOEPThread$RequestHandlerImpl.onConnect(HeaderSet, HeaderSet) passes null for unconditionally dereferenced parameter of String.startsWith(String) CORRECTNESS NP_NULL_PARAM_DEREF 118
Should BluetoothTCKAgent.GOEPThread$RequestHandlerImpl be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available

BluetoothTCKAgent.L2CAPThread

Bug Category Details Line
BluetoothTCKAgent.L2CAPThread.run() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 237
BluetoothTCKAgent.L2CAPThread.message should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available
Exception is caught when Exception is not thrown in BluetoothTCKAgent.L2CAPThread.L2CAPThread(String, String, String) STYLE REC_CATCH_EXCEPTION 114
Write to static field BluetoothTCKAgent.L2CAPThread.message from instance method BluetoothTCKAgent.L2CAPThread.run() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 186
Unread field: BluetoothTCKAgent.L2CAPThread.counter PERFORMANCE URF_UNREAD_FIELD 75

BluetoothTCKAgent.PushBTConnectionThread

Bug Category Details Line
BluetoothTCKAgent.PushBTConnectionThread.connect(String, String, boolean, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 539
BluetoothTCKAgent.PushBTConnectionThread.connect(String, boolean, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 617
Dead store to buffer in BluetoothTCKAgent.PushBTConnectionThread.connect(String, String, boolean, String) STYLE DLS_DEAD_LOCAL_STORE 472
Dead store to buffer in BluetoothTCKAgent.PushBTConnectionThread.connect(String, boolean, String) STYLE DLS_DEAD_LOCAL_STORE 550
Exception is caught when Exception is not thrown in BluetoothTCKAgent.PushBTConnectionThread.run() STYLE REC_CATCH_EXCEPTION 268
Method BluetoothTCKAgent.PushBTConnectionThread.connect(String, String, boolean, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 511
Method BluetoothTCKAgent.PushBTConnectionThread.connect(String, boolean, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 589

BluetoothTCKAgent.System

Bug Category Details Line
BluetoothTCKAgent.System.out isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 36

BluetoothTCKAgent.TCKAgentUtil

Bug Category Details Line
BluetoothTCKAgent.TCKAgentUtil.pause(int) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 52
Dead store to result in BluetoothTCKAgent.TCKAgentUtil.getRemoteDevice(String) STYLE DLS_DEAD_LOCAL_STORE 136
Dead store to L2CAP_UUID in BluetoothTCKAgent.TCKAgentUtil.getServiceRecord(String, int) STYLE DLS_DEAD_LOCAL_STORE 231
Dead store to OBEX_UUID in BluetoothTCKAgent.TCKAgentUtil.getServiceRecord(String, int) STYLE DLS_DEAD_LOCAL_STORE 231
Dead store to RFCOMM_UUID in BluetoothTCKAgent.TCKAgentUtil.getServiceRecord(String, int) STYLE DLS_DEAD_LOCAL_STORE 231
Dead store to transID in BluetoothTCKAgent.TCKAgentUtil.getServiceRecords(String, UUID[]) STYLE DLS_DEAD_LOCAL_STORE 187
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 118
Result of integer multiplication cast to long in BluetoothTCKAgent.TCKAgentUtil.getServiceClass(String, int) STYLE ICAST_INTEGER_MULTIPLY_CAST_TO_LONG 79
BluetoothTCKAgent.TCKAgentUtil.MEDIUM isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 43
BluetoothTCKAgent.TCKAgentUtil.SHORT isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 42
BluetoothTCKAgent.TCKAgentUtil.LONG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 44
Should BluetoothTCKAgent.TCKAgentUtil.getServiceRecords(String, UUID[]) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 181
Unconditional wait in BluetoothTCKAgent.TCKAgentUtil.getRemoteDevice(String) MT_CORRECTNESS UW_UNCOND_WAIT 139
Unconditional wait in BluetoothTCKAgent.TCKAgentUtil.getServiceClass(String, int) MT_CORRECTNESS UW_UNCOND_WAIT 79
Wait not in loop in BluetoothTCKAgent.TCKAgentUtil.getServiceClass(String, int) MT_CORRECTNESS WA_NOT_IN_LOOP 79

OBEXTCKAgent.OBEXTCKAgentApp

Bug Category Details Line
Dead store to agent in OBEXTCKAgent.OBEXTCKAgentApp.runOriginal() STYLE DLS_DEAD_LOCAL_STORE 167
Dead store to canRun in OBEXTCKAgent.OBEXTCKAgentApp.runOriginal() STYLE DLS_DEAD_LOCAL_STORE 182
OBEXTCKAgent.OBEXTCKAgentApp.main(String[]) explicitly invokes run on a thread (did you mean to start it instead?) MT_CORRECTNESS RU_INVOKE_RUN 113
Unread field: OBEXTCKAgent.OBEXTCKAgentApp.BTGOEP_AGENT_SERVICE_SRVCLASS_ID; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 53

OBEXTCKAgent.OBEXTCKAgentApp$MyAuthenticator

Bug Category Details Line
OBEXTCKAgent.OBEXTCKAgentApp$MyAuthenticator.onAuthenticationChallenge(String, boolean, boolean) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 276
OBEXTCKAgent.OBEXTCKAgentApp$MyAuthenticator.onAuthenticationResponse(byte[]) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 293
Should OBEXTCKAgent.OBEXTCKAgentApp$MyAuthenticator be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available

OBEXTCKAgent.OBEXTCKAgentApp$RequestHandlerImpl

Bug Category Details Line
OBEXTCKAgent.OBEXTCKAgentApp$RequestHandlerImpl.onConnect(HeaderSet, HeaderSet) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 460
Unused field: OBEXTCKAgent.OBEXTCKAgentApp$RequestHandlerImpl.testNum PERFORMANCE UUF_UNUSED_FIELD Not available

org.bluecove.tester.tck.TckCanvas

Bug Category Details Line
Write to static field org.bluecove.tester.me.LoggerCanvas.logTimeStamp from instance method org.bluecove.tester.tck.TckCanvas.TckCanvas() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 54